From 45faa860c9e09507ece061bedb80fb8f08a4a76b Mon Sep 17 00:00:00 2001
From: Yann Lanthony <yann.lanthony@gmail.com>
Date: Fri, 8 Feb 2019 15:37:06 +0100
Subject: [PATCH] [ui] AttributeEditor: remove SortFilterDelegateModel

Usage of DelegateModel for model filtering has not proven to be the most stable solution, and might be responsible for random crashes happening during engine's garbage collection.  Implement Loader-based alternative:
* first delegate is a Loader which creates the AttributeItemDelegate if necessary
* compensate spacing using negative height when element is hidden
---
 .../ui/qml/GraphEditor/AttributeEditor.qml    | 30 ++++++++-----------
 1 file changed, 12 insertions(+), 18 deletions(-)

diff --git a/meshroom/ui/qml/GraphEditor/AttributeEditor.qml b/meshroom/ui/qml/GraphEditor/AttributeEditor.qml
index bd7dcbbe..62a6b2f2 100644
--- a/meshroom/ui/qml/GraphEditor/AttributeEditor.qml
+++ b/meshroom/ui/qml/GraphEditor/AttributeEditor.qml
@@ -19,29 +19,23 @@ ListView {
 
     implicitHeight: contentHeight
 
-    clip: true
     spacing: 2
+    clip: true
     ScrollBar.vertical: ScrollBar { id: scrollBar }
 
-    model: SortFilterDelegateModel {
+    model: attributes
 
-        model: attributes
-        filterRole: GraphEditorSettings.showAdvancedAttributes ? "" : "advanced"
-        filterValue: false
+    delegate: Loader {
+        active: !object.desc.advanced || GraphEditorSettings.showAdvancedAttributes
+        visible: active
+        height: item ? item.implicitHeight : -spacing // compensate for spacing if item is hidden
 
-        function modelData(item, roleName) {
-            return item.model.object.desc[roleName]
-        }
-
-        Component {
-            id: delegateComponent
-            AttributeItemDelegate {
-                width: ListView.view.width - scrollBar.width
-                readOnly: root.readOnly
-                labelWidth: root.labelWidth
-                attribute: object
-                onDoubleClicked: root.attributeDoubleClicked(mouse, attr)
-            }
+        sourceComponent: AttributeItemDelegate {
+            width: root.width - scrollBar.width
+            readOnly: root.readOnly
+            labelWidth: root.labelWidth
+            attribute: object
+            onDoubleClicked: root.attributeDoubleClicked(mouse, attr)
         }
     }