3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-08-03 08:48:40 +02:00
Code Issues Projects Releases Packages Wiki Activity

[GraphEditor] AttributePin: Disable connections between GroupAttributes

Browse source 
As connections between groups are currently not supported, add connecting
any `GroupAttribute` to the list of connections to refuse.
This commit is contained in:
Candice Bentéjac 2024-12-30 16:39:15 +01:00
parent 3a1ab9b9df
commit 431c5288d3
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
meshroom/ui/qml/GraphEditor/AttributePin.qml
View file

@ -123,6 +123,7 @@ RowLayout {
|| drag.source.nodeItem === inputDragTarget.nodeItem // Connection between attributes of the same node
|| (drag.source.isList && childrenRepeater.count) // Source/target are lists but target already has children
|| drag.source.connectorType === "input" // Refuse to connect an "input pin" on another one (input attr can be connected to input attr, but not the graphical pin)
|| (drag.source.isGroup || inputDragTarget.isGroup) // Refuse connection between Groups, which is unsupported
) {
// Refuse attributes connection
drag.accepted = false
@ -155,6 +156,7 @@ RowLayout {
readonly property bool isOutput: Boolean(attribute.isOutput)
readonly property string baseType: attribute.baseType !== undefined ? attribute.baseType : ""
readonly property alias isList: root.isList
readonly property alias isGroup: root.isGroup
property bool dragAccepted: false
anchors.verticalCenter: parent.verticalCenter
anchors.horizontalCenter: parent.horizontalCenter
@ -316,6 +318,7 @@ RowLayout {
|| (!drag.source.isList && outputDragTarget.isList) // Connection between a list and a simple attribute
|| (drag.source.isList && childrenRepeater.count) // Source/target are lists but target already has children
|| drag.source.connectorType === "output" // Refuse to connect an output pin on another one
|| (drag.source.isGroup || outputDragTarget.isGroup) // Refuse connection between Groups, which is unsupported
) {
// Refuse attributes connection
drag.accepted = false
@ -343,6 +346,7 @@ RowLayout {
readonly property alias nodeItem: root.nodeItem
readonly property bool isOutput: Boolean(attribute.isOutput)
readonly property alias isList: root.isList
readonly property alias isGroup: root.isGroup
readonly property string baseType: root.attribute.baseType !== undefined ? attribute.baseType : ""
property bool dropAccepted: false
anchors.horizontalCenter: parent.horizontalCenter