3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-04-29 18:27:23 +02:00
Code Issues Projects Releases Packages Wiki Activity

[Node] ExtractMetadata: Replace os.system with subprocess.Popen

Browse source
This commit is contained in:
Vincent Demoulin 2025-01-31 11:29:29 +01:00
parent f1d68b660c
commit 3e854e7b38
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
meshroom/nodes/aliceVision/ExtractMetadata.py
View file

@ -7,6 +7,7 @@ import distutils.dir_util as du
import shutil
import glob
import os
import subprocess
class ExtractMetadata(desc.Node):
@ -106,10 +107,10 @@ Using exifTool, this node extracts metadata of all images referenced in a sfmDat
else: #xmp
cmd = 'exiftool -tagsfromfile ' + iFile + ' ' + chunk.node.arguments.value.strip() + ' ' + oFile
chunk.logger.debug(cmd)
try:
os.system(cmd)
except:
chunk.logger.error("exifTool command failed ! Check that exifTool can be accessed on your system.")
error = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).stderr.read().decode()
chunk.logger.debug(error)
if error != "":
chunk.logger.error(error)
raise RuntimeError(error)
if not os.path.exists(oFile):
info = 'No metadata extracted for file ' + iFile