3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-06-20 11:37:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

[tests] Simplify registration/unregistration of nodes in tests

Browse source 
Add two methods that are local to tests, `registerNodeDesc` and
`unregisterNodeDesc`, which handle the registration and unregistration
of `NodePlugins` from a node description. This reduces the amount of
code in tests whenever `NodePlugin` need to be instantiated prior
to their registration and so on.
This commit is contained in:
Candice Bentéjac 2025-06-04 21:18:16 +02:00
parent 424abbff82
commit 3c57afb4d0
8 changed files with 76 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

41
tests/test_nodeAttributeChangedCallback.py
View file

@ -3,7 +3,8 @@
from meshroom.core.graph import Graph, loadGraph, executeGraph
from meshroom.core import desc, pluginManager
from meshroom.core.node import Node
from meshroom.core.plugins import NodePlugin
from .utils import registerNodeDesc, unregisterNodeDesc
class NodeWithAttributeChangedCallback(desc.BaseNode):
@ -38,15 +39,14 @@ class NodeWithAttributeChangedCallback(desc.BaseNode):
class TestNodeWithAttributeChangedCallback:
nodePlugin = NodePlugin(NodeWithAttributeChangedCallback)
@classmethod
def setup_class(cls):
pluginManager.registerNode(cls.nodePlugin)
registerNodeDesc(NodeWithAttributeChangedCallback)
@classmethod
def teardown_class(cls):
pluginManager.unregisterNode(cls.nodePlugin)
unregisterNodeDesc(NodeWithAttributeChangedCallback)
def test_assignValueTriggersCallback(self):
node = Node(NodeWithAttributeChangedCallback.__name__)
@ -71,15 +71,14 @@ class TestNodeWithAttributeChangedCallback:
class TestAttributeCallbackTriggerInGraph:
nodePlugin = NodePlugin(NodeWithAttributeChangedCallback)
@classmethod
def setup_class(cls):
pluginManager.registerNode(cls.nodePlugin)
registerNodeDesc(NodeWithAttributeChangedCallback)
@classmethod
def teardown_class(cls):
pluginManager.unregisterNode(cls.nodePlugin)
unregisterNodeDesc(NodeWithAttributeChangedCallback)
def test_connectionTriggersCallback(self):
graph = Graph("")
@ -246,18 +245,16 @@ class NodeWithCompoundAttributes(desc.BaseNode):
class TestAttributeCallbackBehaviorWithUpstreamCompoundAttributes:
nodePluginAttributeChangedCallback = NodePlugin(NodeWithAttributeChangedCallback)
nodePluginCompoundAttributes = NodePlugin(NodeWithCompoundAttributes)
@classmethod
def setup_class(cls):
pluginManager.registerNode(cls.nodePluginAttributeChangedCallback)
pluginManager.registerNode(cls.nodePluginCompoundAttributes)
registerNodeDesc(NodeWithAttributeChangedCallback)
registerNodeDesc(NodeWithCompoundAttributes)
@classmethod
def teardown_class(cls):
pluginManager.unregisterNode(cls.nodePluginAttributeChangedCallback)
pluginManager.unregisterNode(cls.nodePluginCompoundAttributes)
unregisterNodeDesc(NodeWithAttributeChangedCallback)
unregisterNodeDesc(NodeWithCompoundAttributes)
def test_connectionToListElement(self):
graph = Graph("")
@ -349,18 +346,18 @@ class NodeWithDynamicOutputValue(desc.BaseNode):
class TestAttributeCallbackBehaviorWithUpstreamDynamicOutputs:
nodePluginAttributeChangedCallback = NodePlugin(NodeWithAttributeChangedCallback)
nodePluginDynamicOutputValue = NodePlugin(NodeWithDynamicOutputValue)
# nodePluginAttributeChangedCallback = NodePlugin(NodeWithAttributeChangedCallback)
# nodePluginDynamicOutputValue = NodePlugin(NodeWithDynamicOutputValue)
@classmethod
def setup_class(cls):
pluginManager.registerNode(cls.nodePluginAttributeChangedCallback)
pluginManager.registerNode(cls.nodePluginDynamicOutputValue)
registerNodeDesc(NodeWithAttributeChangedCallback)
registerNodeDesc(NodeWithDynamicOutputValue)
@classmethod
def teardown_class(cls):
pluginManager.unregisterNode(cls.nodePluginAttributeChangedCallback)
pluginManager.unregisterNode(cls.nodePluginDynamicOutputValue)
unregisterNodeDesc(NodeWithAttributeChangedCallback)
unregisterNodeDesc(NodeWithDynamicOutputValue)
def test_connectingUncomputedDynamicOutputDoesNotTriggerDownstreamAttributeChangedCallback(
self,
@ -443,15 +440,13 @@ class TestAttributeCallbackBehaviorWithUpstreamDynamicOutputs:
class TestAttributeCallbackBehaviorOnGraphImport:
nodePlugin = NodePlugin(NodeWithAttributeChangedCallback)
@classmethod
def setup_class(cls):
pluginManager.registerNode(cls.nodePlugin)
registerNodeDesc(NodeWithAttributeChangedCallback)
@classmethod
def teardown_class(cls):
pluginManager.unregisterNode(cls.nodePlugin)
unregisterNodeDesc(NodeWithAttributeChangedCallback)
def test_importingGraphDoesNotTriggerAttributeChangedCallbacks(self):
graph = Graph("")