3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-08-03 16:58:24 +02:00
Code Issues Projects Releases Packages Wiki Activity

[ui] improve performance on image reconstruction status

Browse source 
*  look-up in views/poses (exposed as QVariant) on QML side is not efficient
*  move this logic to the Python side and expose it as dedicated slots
This commit is contained in:
Yann Lanthony 2018-01-25 12:52:11 +01:00
parent 40fdddee05
commit 3965be049b
2 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
meshroom/ui/reconstruction.py
View file

@ -399,8 +399,18 @@ class Reconstruction(UIGraph):
self._sfm.chunks[0].statusChanged.connect(self.updateViewsAndPoses)
self.sfmChanged.emit()
@Slot(QObject, result=bool)
def isInViews(self, viewpoint):
# keys are strings (faster lookup)
return str(viewpoint.viewId.value) in self._views
@Slot(QObject, result=bool)
def isReconstructed(self, viewpoint):
# keys are strings (faster lookup)
return str(viewpoint.poseId.value) in self._poses
sfmChanged = Signal()
sfm = Property(QObject, getSfm, setSfm, notify=sfmChanged)
sfmReportChanged = Signal()
views = Property("QVariant", lambda self: self._views, notify=sfmReportChanged)
poses = Property("QVariant", lambda self: self._poses, notify=sfmReportChanged)
# convenient property for QML binding re-evaluation when sfm report changes
sfmReport = Property(bool, lambda self: len(self._poses) > 0, notify=sfmReportChanged)