From 349de9a3a602fe8d91bdef84d751731f059ee92c Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Mon, 28 Jan 2019 10:22:25 +0100 Subject: [PATCH] [nodes] expose estimator parameters on sfm and features matching --- meshroom/nodes/aliceVision/FeatureMatching.py | 11 ++++++++++ .../nodes/aliceVision/StructureFromMotion.py | 20 +++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/meshroom/nodes/aliceVision/FeatureMatching.py b/meshroom/nodes/aliceVision/FeatureMatching.py index 0c487150..d032f876 100644 --- a/meshroom/nodes/aliceVision/FeatureMatching.py +++ b/meshroom/nodes/aliceVision/FeatureMatching.py @@ -105,6 +105,17 @@ class FeatureMatching(desc.CommandLineNode): uid=[0], advanced=True, ), + desc.FloatParam( + name='geometricError', + label='Geometric Validation Error', + description='Maximum error (in pixels) allowed for features matching during geometric verification.\n' + 'If set to 0, it will select a threshold according to the localizer estimator used\n' + '(if ACRansac, it will analyze the input data to select the optimal value).', + value=0.0, + range=(0.0, 10.0, 0.1), + uid=[0], + advanced=True, + ), desc.IntParam( name='maxMatches', label='Max Matches', diff --git a/meshroom/nodes/aliceVision/StructureFromMotion.py b/meshroom/nodes/aliceVision/StructureFromMotion.py index 387732e4..1761e6d6 100644 --- a/meshroom/nodes/aliceVision/StructureFromMotion.py +++ b/meshroom/nodes/aliceVision/StructureFromMotion.py @@ -62,6 +62,26 @@ class StructureFromMotion(desc.CommandLineNode): uid=[0], advanced=True, ), + desc.IntParam( + name='localizerEstimatorMaxIterations', + label='Localizer Max Ransac Iterations', + description='Maximum number of iterations allowed in ransac step.', + value=4096, + range=(1, 20000, 1), + uid=[0], + advanced=True, + ), + desc.FloatParam( + name='localizerEstimatorError', + label='Localizer Max Ransac Error', + description='Maximum error (in pixels) allowed for camera localization (resectioning).\n' + 'If set to 0, it will select a threshold according to the localizer estimator used\n' + '(if ACRansac, it will analyze the input data to select the optimal value).', + value=0.0, + range=(0.0, 100.0, 0.1), + uid=[0], + advanced=True, + ), desc.BoolParam( name='lockScenePreviouslyReconstructed', label='Lock Scene Previously Reconstructed',