3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-07-15 15:55:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

[core] declaring "global" var access is useless

Browse source
This commit is contained in:
Fabien Castan 2025-04-14 10:50:57 +02:00
parent b9a5c00279
commit 2ad55352ee
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
meshroom/core/__init__.py
View file

@ -310,7 +310,6 @@ def registerNodeType(nodeType):
After registration, nodes of this type can be instantiated in a Graph. After registration, nodes of this type can be instantiated in a Graph.
""" """
global nodesDesc
if nodeType.__name__ in nodesDesc: if nodeType.__name__ in nodesDesc:
logging.error(f"Node Desc {nodeType.__name__} is already registered.") logging.error(f"Node Desc {nodeType.__name__} is already registered.")
nodesDesc[nodeType.__name__] = nodeType nodesDesc[nodeType.__name__] = nodeType
@ -318,7 +317,6 @@ def registerNodeType(nodeType):
def unregisterNodeType(nodeType): def unregisterNodeType(nodeType):
""" Remove 'nodeType' from the list of register node types. """ """ Remove 'nodeType' from the list of register node types. """
global nodesDesc
assert nodeType.__name__ in nodesDesc assert nodeType.__name__ in nodesDesc
del nodesDesc[nodeType.__name__] del nodesDesc[nodeType.__name__]
@ -332,7 +330,6 @@ def loadNodes(folder, packageName):
def loadAllNodes(folder): def loadAllNodes(folder):
global nodesDesc
for importer, package, ispkg in pkgutil.walk_packages([folder]): for importer, package, ispkg in pkgutil.walk_packages([folder]):
if ispkg: if ispkg:
nodeTypes = loadNodes(folder, package) nodeTypes = loadNodes(folder, package)
@ -372,7 +369,6 @@ def loadPluginsFolder(folder):
def registerSubmitter(s): def registerSubmitter(s):
global submitters
if s.name in submitters: if s.name in submitters:
logging.error(f"Submitter {s.name} is already registered.") logging.error(f"Submitter {s.name} is already registered.")
submitters[s.name] = s submitters[s.name] = s
@ -387,7 +383,6 @@ def loadSubmitters(folder, packageName):
def loadPipelineTemplates(folder): def loadPipelineTemplates(folder):
global pipelineTemplates
if not os.path.isdir(folder): if not os.path.isdir(folder):
logging.error(f"Pipeline templates folder '{folder}' does not exist.") logging.error(f"Pipeline templates folder '{folder}' does not exist.")
return return

4
meshroom/core/node.py
View file

@ -298,12 +298,11 @@ class LogManager:
return logging.NOTSET return logging.NOTSET
runningProcesses = {} runningProcesses: dict[str, "NodeChunk"] = {}
@atexit.register @atexit.register
def clearProcessesStatus(): def clearProcessesStatus():
global runningProcesses
for k, v in runningProcesses.items(): for k, v in runningProcesses.items():
v.upgradeStatusTo(Status.KILLED) v.upgradeStatusTo(Status.KILLED)
@ -474,7 +473,6 @@ class NodeChunk(BaseObject):
self._processInIsolatedEnvironment() self._processInIsolatedEnvironment()
return return
global runningProcesses
runningProcesses[self.name] = self runningProcesses[self.name] = self
self._status.setNode(self.node) self._status.setNode(self.node)
self._status.initStartCompute() self._status.initStartCompute()