From 12249de216e44fbc185fa3c5a62d07d9a3a0fcb0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Candice=20Bent=C3=A9jac?= Date: Fri, 4 Oct 2024 18:08:16 +0200 Subject: [PATCH] [GraphEditor] Stop manually editing pins based on the edge's visibility Editing the pins manually was useful when trying to hide fully the connection whenever there was an edge connected to an attribute that was disabled. Disabled attributes now have a special display if they are connected, meaning both ends of the edge do not need artificial updates. --- meshroom/ui/qml/GraphEditor/GraphEditor.qml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/meshroom/ui/qml/GraphEditor/GraphEditor.qml b/meshroom/ui/qml/GraphEditor/GraphEditor.qml index 62de8796..c55ca2e2 100755 --- a/meshroom/ui/qml/GraphEditor/GraphEditor.qml +++ b/meshroom/ui/qml/GraphEditor/GraphEditor.qml @@ -521,22 +521,6 @@ Item { } } } - onVisibleChanged: { - if (visible) { - // Enable the pins on both sides - src.updatePin(true, true) // isSrc = true, isVisible = true - dst.updatePin(false, true) // isSrc = false, isVisible = true - } else { - // One of the attributes is visible, we do not need to handle the case where both attributes are hidden - if (isValidEdge && (src.visible || dst.visible)) { - if (src.visible) { - src.updatePin(true, false) // isSrc = true, isVisible = false - } else { - dst.updatePin(false, false) // isSrc = false, isVisible = false - } - } - } - } Component.onDestruction: { // Handles the case where the edge is destroyed while hidden because it is replaced: the pins should be re-enabled