3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-04-28 17:57:16 +02:00
Code Issues Projects Releases Packages Wiki Activity

[ui] GraphEditor: cache selected node computability status

Browse source 
Avoid to evaluate the computability/submitability status of each
node twice by caching the information when creating the node
context menu.
This commit is contained in:
Yann Lanthony 2024-12-06 10:14:50 +01:00
parent ade1f87b8f
commit 107b1e959a
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
meshroom/ui/qml/GraphEditor/GraphEditor.qml
View file

@ -572,11 +572,22 @@ Item {
property var currentNode: nodeMenuLoader.currentNode property var currentNode: nodeMenuLoader.currentNode
// Cache computatibility/submitability status of each selected node.
readonly property var nodeSubmitOrComputeStatus: {
var collectedStatus = ({});
uigraph.nodeSelection.selectedIndexes.forEach(function(idx) {
const node = uigraph.graph.nodes.at(idx.row);
collectedStatus[node] = uigraph.graph.canSubmitOrCompute(node);
});
return collectedStatus;
}
readonly property bool isSelectionFullyComputed: { readonly property bool isSelectionFullyComputed: {
return uigraph.nodeSelection.selectedIndexes.every(function(idx) { return uigraph.nodeSelection.selectedIndexes.every(function(idx) {
return uigraph.graph.nodes.at(idx.row).isComputed; return uigraph.graph.nodes.at(idx.row).isComputed;
}); });
} }
readonly property bool isSelectionOnlyComputableNodes: { readonly property bool isSelectionOnlyComputableNodes: {
return uigraph.nodeSelection.selectedIndexes.every(function(idx) { return uigraph.nodeSelection.selectedIndexes.every(function(idx) {
const node = uigraph.graph.nodes.at(idx.row); const node = uigraph.graph.nodes.at(idx.row);
@ -586,6 +597,7 @@ Item {
); );
}); });
} }
readonly property bool canSelectionBeComputed: { readonly property bool canSelectionBeComputed: {
if(!isSelectionOnlyComputableNodes) if(!isSelectionOnlyComputableNodes)
return false; return false;
@ -596,10 +608,11 @@ Item {
return ( return (
node.isComputed node.isComputed
// canCompute if canSubmitOrCompute == 1(can compute) or 3(can compute & submit) // canCompute if canSubmitOrCompute == 1(can compute) or 3(can compute & submit)
|| uigraph.graph.canSubmitOrCompute(node) % 2 == 1 || nodeSubmitOrComputeStatus[node] % 2 == 1
); );
}); });
} }
readonly property bool isSelectionSubmittable: uigraph.canSubmit && isSelectionOnlyComputableNodes readonly property bool isSelectionSubmittable: uigraph.canSubmit && isSelectionOnlyComputableNodes
readonly property bool canSelectionBeSubmitted: { readonly property bool canSelectionBeSubmitted: {
@ -612,7 +625,7 @@ Item {
return ( return (
node.isComputed node.isComputed
// canSubmit if canSubmitOrCompute == 2(can submit) or 3(can compute & submit) // canSubmit if canSubmitOrCompute == 2(can submit) or 3(can compute & submit)
|| uigraph.graph.canSubmitOrCompute(node) > 1 || nodeSubmitOrComputeStatus[node] > 1
) )
}); });
} }