3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-08-04 01:08:26 +02:00
Code Issues Projects Releases Packages Wiki Activity

[qt6][GraphEditor] Fix connections to ListAttribute pins

Browse source 
The callbacks of `childrenRepeater` (which was used to "fill"
`ListAttributes` with children) were not correctly set. Their prototypes
were missing the `index` argument, meaning that instead of being
provided with the child attribute that was added or deleted,
they were provided with its index in the model.

The added children attributes were also instatiated as empty attribute
pins that were still visible, thus increasing indirectly the spacing of
the initial pin.
This commit is contained in:
Candice Bentéjac 2024-10-10 19:31:56 +02:00
parent 52444ef0ad
commit 039504782f
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
meshroom/ui/qml/GraphEditor/AttributePin.qml
View file

@ -58,10 +58,11 @@ RowLayout {
Repeater {
id: childrenRepeater
model: isList && !attribute.isLink ? attribute.value : 0
onItemAdded: function(item) { childPinCreated(item.childAttribute, item) }
onItemRemoved: function(item) { childPinDeleted(item.childAttribute, item) }
onItemAdded: function(index, item) { childPinCreated(item.childAttribute, root) }
onItemRemoved: function(index, item) { childPinDeleted(item.childAttribute, root) }
delegate: Item {
property var childAttribute: object
visible: false
}
}